kubernetes-sigs / kubebuilder / 27686259311

83%

master: 83%

Pull #5765

github

🐛 (helm/v2-alpha): fix helm-deploy deploying image ":0.1.0" when IMG is unset

The scaffolded helm-deploy target referenced $IMG via shell expansion,
but IMG is a Make variable not exported to the recipe shell, so a plain
`make helm-deploy` sent empty --set flags and deployed image ":0.1.0".

- pass IMG into the recipe shell explicitly in the Makefile template
- add a template-level default for manager.image.repository in the chart
- run helm-deploy without IMG in the chart test workflow to cover the default path

2 of 2 new or added lines in 1 file covered. (100.0%)

7837 of 9468 relevant lines covered (82.77%)

81.0 hits per line