IntelPython / dpnp / 27705513053

78%

push

github

Removed support for arrays of 2-dimensional vectors in dpnp.cross (#2950)

NumPy 2.5 expires the deprecation of 2-dimensional vectors in
`numpy.cross`: the function now requires (arrays of) 3-dimensional
vectors and raises `ValueError` otherwise.

This PR brings `dpnp.cross` in line with that behavior.
Dpnp had already deprecated 2-D vectors in `dpnp.cross` back in 0.17.0
(via `DeprecationWarning`), so this removes the deprecated path
entirely.

Note, `dpnp.cross` now rejects 2-D vectors unconditionally, including
when running tests against `NumPy < 2.5` (where numpy.cross still
computes a 2-D result). This is an intentional.

1532 of 2854 branches covered (53.68%)

Branch coverage included in aggregate %.

16 of 17 new or added lines in 2 files covered. (94.12%)

25975 of 32370 relevant lines covered (80.24%)

8018.25 hits per line