comunica / traqula / 27701555098

100%

main: 100%

Pull #149

github

fix(test-utils): tighten CJS guard, fix sideEffects, drop stale eslint ignore

- Remove dead 'packages/test-utils/scripts/**' ignore from eslint.config.js;
  the scripts/ directory belonged to an abandoned post-build-script approach
  and no longer exists on the branch.

- Add a second case to cjs.test.ts that require()s the actual compiled
  dist/cjs/lib/indexCjs.js (the real CJS entry point, not just utils.js).
  Loading the full entry point triggers vitest's own CJS-import guard because
  indexCjs.js re-exports matchers/vitest.js.  The test therefore asserts that
  the error is specifically vitest's guard error (a plain Error with a
  recognisable message) rather than a SyntaxError from leftover import.meta.url
  in the compiled output — proving the CJS build itself is syntactically valid.

- Change "sideEffects": false → "sideEffects": ["**/index.js", "**/indexCjs.js"]
  in packages/test-utils/package.json.  Both entry points call _initStaticsRoot
  at module-eval time, which is a real side effect; leaving the field as false
  would allow a tree-shaker to drop the init and trigger the "called before
  init" throw at runtime.

- Expand the _initStaticsRoot JSDoc in utils.ts with a design-note paragraph
  explaining why eager-init-with-anchored-walk-up was chosen over a fully-lazy
  alternative, and pointing to the sideEffects tension as the place to raise
  any future architectural discussion.

Note: the depcheck step of the pre-commit hook fails on '@comunica/config-query-sparql-next'
and '@comunica/utils-algebra-next', which are packages from the outer comunica workspace that
lerna mistakenly discovers when run in the nested traqula workspace setup.  This failure is
pre-existing on the branch (reproducible with no changes) and is unrelated to this commit.
The traqula packages themselves all pass depcheck individually.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

759 of 759 branches covered (100.0%)

Branch coverage included in aggregate %.

18 of 18 new or added lines in 3 files covered. (100.0%)

5474 of 5474 relevant lines covered (100.0%)

282861.01 hits per line