ghga-de / ghga-registry-service / 27695990601

92%

push

github

Support Box Deletion (GSI-2424) (#16)

* Add FileController method to remove mappings

* Add box deletion method for AuditRepository

* Account for potential race condition in box listing

* Add fub deletion method to the FileBoxClient

* Add box deletion logic to the core

* Modify FUB deletion event sub method to log at INFO instead of WARNING

* Add HttpBoxStateError

* Add unit tests for RDUBManager

* Add AuditRepository unit test

* Add the HTTP API endpoint for rdub deletion

* Add unit tests for the API

* Add a unit test for the FileBoxClient

* Improve FileBoxClient response parsing and 409 error handling

* Remove unreachable BoxAccessError branch

* Revoke grants after FUB deletion

* Obey mypy

* Return empty list for get_file_upload_list() if FUB is not found

* Update doc string for delete_research_data_upload_box()

* Update src/rs/core/rdub_manager.py

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>

* Update src/rs/adapters/outbound/http.py

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>

* Update src/rs/adapters/outbound/http.py

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>

* Enhance get_file_upload_list to handle missing FileUploadBox gracefully

- Added missing_box_ok parameter to get_file_upload_list method in FileBoxClient and FileBoxClientPort.
- Updated logic to return an empty list instead of raising an error when the FileUploadBox is not found and missing_box_ok is True.
- Modified RDUBManager to call get_file_upload_list with missing_box_ok set to True.
- Added tests to verify behavior for both scenarios (with and without missing_box_ok).

---------

Co-authored-by: Christoph Zwerschke <c.zwerschke@dkfz-heidelberg.de>

147 of 157 new or added lines in 12 files covered. (93.63%)

1230 of 1345 relevant lines covered (91.45%)

0.91 hits per line