kubernetes-sigs / kubebuilder / 27668093647

83%

master: 83%

Pull #5764

github

fix(helm/v2-alpha): strip custom volumes from deployment object to prevent duplication

Custom volumes (e.g. user-added configMaps, secrets) appeared both as
literal entries in the generated manager.yaml template AND via
{{ toYaml .Values.manager.extraVolumes }}, causing duplication at install time.

The fix is in the extractor: extractExtraVolumes and extractExtraVolumeMounts
now remove custom volumes from the resource object after extracting them for
values.yaml. Since yaml.Marshal runs on the cleaned object, custom volumes
never appear in the template — they only flow through values.yaml.

System volumes (webhook-certs, metrics-certs) are kept in the object so they
render as conditionals in the template.

Signed-off-by: Prashanth Venkatesh <prash.v.2512@gmail.com>

30 of 37 new or added lines in 2 files covered. (81.08%)

7876 of 9499 relevant lines covered (82.91%)

82.38 hits per line