open-source-parsers / jsoncpp / 27674927749

90%

push

github

fix: bump SOVERSION to 28 for the removed std::string_view symbols (#1694) (#1697)

The std::string_view convenience methods (Value(std::string_view),
getString, operator[], get, removeMember, isMember) were exported
symbols in 1.9.7 -- declared in value.h and defined out-of-line in
value.cpp. After 1.9.7 the #1661/#1675 ABI-mismatch fixes made them
header-only `inline`, which removed those symbols from the shared
library (e.g. Value::removeMember(std::string_view)), but SOVERSION
stayed at 27.

Removing exported symbols is an incompatible ABI change, so consumers
built against 1.9.7's libjsoncpp.so.27 fail to resolve those symbols
against later builds that still claim SONAME .so.27 (issue #1694: a
system jsoncpp upgrade broke cmake/NFS Ganesha with an undefined-symbol
error). Bump SOVERSION 27 -> 28 so the changed ABI gets a distinct
SONAME; affected consumers then get a clean rebuild requirement instead
of a symbol-lookup crash, and a rebuild against 1.10.0 uses the inline
methods (no symbol dependency).

The symbols are intentionally not restored: an exported std::string_view
symbol's presence depends on whether the library was compiled as C++17,
which is the mismatch #1661 fixed.

2220 of 2638 branches covered (84.15%)

Branch coverage included in aggregate %.

2615 of 2740 relevant lines covered (95.44%)

23827.05 hits per line