supabase / supabase / 27650944034

75%

push

github

chore: refactor `Button` API so that it can be used a standard `button` (#46880)

## Problem

Our `<Button>` component breaks the default `button` contract by
redefining the `type` prop to set its variant (`primary`, `default`,
etc) instead of the button type (`submit`, `button`, etc).
This is confusing and forces to write more code when using it with
shadcn components that expect/inject the standard button props.

## Solution

- rename the `type` prop to `variant`
- rename the `htmlType` prop to `type`
- propagate the changes where necessary
- format code

## How to test

As this is just prop renaming, if it builds it's ok

---------

Co-authored-by: Ivan Vasilov <vasilov.ivan@gmail.com>

997 of 1392 branches covered (71.62%)

Branch coverage included in aggregate %.

1528 of 2086 relevant lines covered (73.25%)

250.08 hits per line