open-source-parsers / jsoncpp / 27649973372

90%

push

github

fix: make array operator[] dense when assigning past the end (#1611) (#1693)

* fix: make array operator[] dense when assigning past the end (#1611)

Value::operator[](ArrayIndex) only inserted the requested index, so
`arr[5] = x` on an empty array stored a single element while size()
reported 6 (highest index + 1) and serialization emitted six elements
(missing indices written as null). Range-for iteration walked the
underlying sparse map and therefore visited only the one populated
element -- inconsistent with both size() and the serialized output.

JSON arrays are dense, so materialize the intervening indices as null
when assigning beyond the current end, exactly as resize() already does
when growing. Iteration, size(), equality, and serialization now agree.

Note: this is a behavior change (arrays are now dense in memory after a
sparse-looking assignment), so it targets the 1.10.0 minor release rather
than a 1.9.x patch. It is ABI-compatible (no signature or layout change),
so SOVERSION is unchanged.

* chore: bump version to 1.10.0

master becomes the 1.10 line. The #1611 array fix changes runtime
behavior (dense arrays) for existing valid code, so the next release is
a minor bump, not a 1.9.x patch. SOVERSION stays at 27 (ABI unchanged).

2212 of 2626 branches covered (84.23%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

2608 of 2732 relevant lines covered (95.46%)

23810.16 hits per line