scriptype / writ-cms / 27648284015

54%

Build Type

push

github

Committed by scriptype

Commit Message

Keep contentTree fresh on update entry

To allow that to happen, api returns the fresh path of updated entry, so
contentPanel can re-fetch contentModel, find the updated node by using
the fresh path and pass the node back to editor.

But fetching contentModel right after updateEntry caused a race
condition (even when updateEntry was awaited). Because, updateEntry
triggers a new build, and server was not waiting until it's finished.

After some playing around, manually triggering build on post update
endpoint and wrapping it with flag setters to guard watcher looked like
the most robust option to fix the issue. A guardWatcher middleware on
the horizon.

One finding from the playing around is how to reproduce #19: Removing
await from watcher onChange and thus racing the conditions.

Coverage Stats

647 of 1119 branches covered (57.82%)

Branch coverage included in aggregate %.

1 of 57 new or added lines in 8 files covered. (1.75%)

3 existing lines in 3 files now uncovered.

2242 of 3925 relevant lines covered (57.12%)

921.64 hits per line