stacklok / toolhive / 27633080957

67%

Build Type

push

github

Committed by web-flow

Commit Message

Add vMCP core/server config derivation helpers (#5513)

* Add vMCP core/server config derivation helpers

Phase 3.1 of the RFC THV-0076 config decomposition. The single in-memory
server.Config is the last god-config that couples the domain core to the
transport. Introduce two unexported helpers that map it onto the already-
existing core.Config (Phase 1) and transport ServerConfig (Phase 2):

- deriveServerConfig projects the transport-only fields plus the
  cross-cutting TelemetryProvider/AuditConfig (R3); the built health
  monitor (A2), shared backend registry, and assembled session-manager
  FactoryConfig are threaded in by the composition root since
  server.Config does not carry them. AuthzMiddleware is not projected —
  ServerConfig has no such field; authz moved to the core admission seam.
- deriveCoreConfig assembles core.Config from cfg's cross-cutting fields
  (ServerName uses the raw cfg.Name for authz parity) plus the
  collaborators passed through rather than reached out of cfg.

Both treat cfg as read-only (no defaulting write-back like server.New).
This only adds the helpers and their tests; #5445 rewires server.New to
call them through Serve. server.New and all serialized formats are
unchanged.

Closes #5444

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Resolve vMCP transport defaults at the edge

Addresses PR review (Option 1): the cmp.Or transport defaults previously
lived in three projection functions (server.New, buildServeConfig,
deriveServerConfig) with a duplicated "which fields" list, and server.New
applied them by mutating the caller's Config in place.

Consolidate to a single resolver, WithDefaults, and resolve once at the
composition root (cli/serve.go):

- WithDefaults is now the only place the transport default list lives.
- deriveServerConfig and buildServeConfig become pure pass-through.
- server.New calls WithDefaults on a COPY, so it no longer mutates the
  caller's Config. That non-mutation... (continued)

Coverage Stats

65 of 67 new or added lines in 4 files covered. (97.01%)

105 existing lines in 4 files now uncovered.

68861 of 102838 relevant lines covered (66.96%)

63.71 hits per line