stacklok / toolhive / 27626418201

67%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate sibling config controllers to MutateAndPatchStatus/Spec (#5509)

* Use MutateAndPatchStatus/Spec in MCPOIDCConfig controller

Status writes now flow through controllerutil.MutateAndPatchStatus and
finalizer writes through controllerutil.MutateAndPatchSpec, matching the
MCPAuthzConfig controller migration in #4777. The previous r.Status().Update
calls sent full PUT bodies that would clobber conditions written by any
disjoint owner of Status.Conditions on this CRD; the previous r.Update calls
had no optimistic-lock guard around the finalizer array.

Condition and field mutations move inside the helper closures so the
pre-mutate snapshot reflects the live state rather than already containing the
change — a MutateAndPatchStatus prerequisite. A small helper,
setOIDCConfigValidTrueCondition, factors out the Valid=True transition.

Add a PreservesForeignConditions regression test mirroring the MCPAuthzConfig
guard, asserting a foreign-owned condition survives a reconcile.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Use MutateAndPatchStatus/Spec in MCPExternalAuthConfig controller

Status writes now flow through controllerutil.MutateAndPatchStatus and
finalizer writes through controllerutil.MutateAndPatchSpec, matching the
MCPAuthzConfig and MCPOIDCConfig controllers. The previous r.Status().Update
calls sent full PUT bodies that would clobber conditions owned by any disjoint
writer of Status.Conditions on this CRD; the previous r.Update calls had no
optimistic-lock guard around the finalizer array.

The IdentitySynthesized advisory was previously computed once in memory before
validation. Because MutateAndPatchStatus snapshots the object on entry and any
pre-mutate change is dropped from the merge patch, that upfront mutation is
removed; the advisory is now recomputed inside each status-write closure via a
new setValidTrueAndSynthesized helper (and directly on the validation-failure
and setInvalid paths). applyIdentitySyn... (continued)

Coverage Stats

129 of 136 new or added lines in 2 files covered. (94.85%)

8 existing lines in 4 files now uncovered.

68810 of 102802 relevant lines covered (66.93%)

63.63 hits per line