aelassas / servy / 27620674396

85%

Build Type

push

github

Committed by aelassas

Commit Message

fix(core): ServiceDependencyNode.cs - constructor parameter 'isCycle' initializes property 'IsCyclic', breaking the parameter/property naming symmetry of its siblings (#3261)
fix(service): StartOptions.cs - StdOutPath/StdErrPath vs PreLaunchStdoutPath/PreLaunchStderrPath: inconsistent Out/out, Err/err casing (#3725)
fix(desktop): ViewModels/Items - ProcessPriorityItem.Priority breaks the property-naming convention used by its 3 sibling Item classes (#3505)
fix(desktop): DesignTimeMocks.cs (Servy) - plural 'Mocks' filename holds a single class (DesignTimeServiceCommands) that doesn't match the file (#3395)
fix(manager): DesignTimeMocks.cs (Manager) - plural 'Mocks' filename holds a single class whose name doesn't match the file (#3284)
fix(core,infra): GlobalUsings.cs (Servy.Core, Servy.Infrastructure) - file contains no global using directives, only the Fody assembly attribute (#3192)
fix(core): ServiceManager.cs - private helper named ChangeServiceConfig2(handle, bool) after the API it wraps, while sibling EnablePreShutdown is purpose-named (#3650)
fix(core): ProtectedKeyProvider.cs - private field 'DataProtectionScope' shadows its own type name ('Color Color' pattern), making call sites ambiguous to readers (#3236)
fix(core): RegexWrapper.cs - redundant System. qualifier on ArgumentNullException (siblings use the unqualified name) (#2692)
fix(core): ServiceControllerWrapper.cs - Core-layer comment says children are sorted 'before adding to the TreeView', leaking a UI concern into Servy.Core (#3256)
fix(cli): BaseCommand.cs - ExecuteWithHandling(Async) summary says 'Catches UnauthorizedAccessException' but catches OperationCanceledException (not mentioned) (#2690)
fix(manager): IServiceCommands.cs - CopyPidAsync is the only member without a CancellationToken parameter (#3289)
fix(manager): Servy.Manager - dispose-guard field spelled four ways (_isDisposed int/bool, _disposedValue, _disposed) across seven sibling classes (#3337)

Coverage Stats

1911 of 2175 branches covered (87.86%)

Branch coverage included in aggregate %.

44 of 46 new or added lines in 16 files covered. (95.65%)

6 existing lines in 2 files now uncovered.

12991 of 15304 relevant lines covered (84.89%)

91.73 hits per line