kubeflow / trainer / 27618906545

65%

Build Type

push

github

Committed by web-flow

Commit Message

feat: inject PET_* envs into init containers via envInjection config (#3516)

* feat: inject PET envs into init containers via envInjection config

- Add EnvInjection and EnvInjectionTarget types to TorchMLPolicySource
- Add FindContainerByPodSetName helper in runtime package
- Update torch plugin to inject PET envs into additional containers
- Update jobset plugin to sync init containers
- Add 5 comprehensive unit tests for envInjection scenarios
- Add Python API models for envInjection types

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: add missing +optional markers for kubeapilinter validation

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: change JobName to optional field for kubeapilinter

Change JobName from required to optional with omitempty tag to satisfy
kubeapilinter validation. Add default marker to CRD schema for listMapKey
requirement.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix test

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: address envInjection review feedback

Reject missing envInjection targets instead of silently skipping them, align the API schema with required fields, and harden init container propagation so misconfigured runtimes fail predictably.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: sync envInjection generated files

Add the generated boilerplate and Python model updates expected by make generate so CI does not report stale generated assets.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: satisfy kube API lint for envInjection fields

Keep the envInjection fields marked as required while preserving omitempty tags required by kubeapilinter.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: update envInjection OpenAPI defaults

Sync generated OpenAPI and Python model output after restoring omitempty on required envInjection fields.

Signed-off-by: Peter Pan <Peter.Pan@daocloud.io>

* fix: address latest review comments

Signed-off-by: Peter Pa... (continued)

Coverage Stats

87 of 94 new or added lines in 3 files covered. (92.55%)

3 existing lines in 1 file now uncovered.

2333 of 3610 relevant lines covered (64.63%)

0.75 hits per line