supabase / supabase-swift / 27609350658

81%

Build Type

push

github

Committed by web-flow

Commit Message

fix(realtime): prevent deaf socket from duplicate handleConnected (SDK-959) (#1003)

* fix(realtime): prevent deaf socket from duplicate handleConnected (SDK-959)

`handleConnected(conn:)` could run twice for the same physical
connection — once synchronously from `connect()` and once from the
state-observer task when a `connect()` call (via `ensureSocketConnected`)
landed while an auto-reconnect was in flight. Each invocation re-read
`conn.events`, which reinstalls `onEvent` and registers a
`continuation.onTermination` that nils `onEvent`. When the first
event-stream's task was torn down, its `onTermination` fired and wiped
the live `onEvent`, leaving the socket connected but unable to receive
any frames.

The deaf socket dropped heartbeat and `phx_join` replies, so heartbeats
timed out every ~50s, recycling the socket and killing the in-flight
JOIN. The first channel subscribe stalled for 50s–7min until a cycle
happened to avoid the race. Introduced by the ConnectionManager
extraction in #855 (v2.44.1).

Make `handleConnected` idempotent per connection: only run
`listenForMessages` / `startHeartbeating` / `flushSendBuffer` when the
connection is new (identity guard against the cached connection), so
`conn.events` is read exactly once per socket. `rejoinChannels()` still
runs on the reconnect path regardless.

Linear: SDK-959

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(realtime): cover cold-start deafness and stale connection signals (SDK-959)

Deeper investigation of SDK-959 found the cold-start trigger and two more
defects in the same family, all stemming from lifecycle events not being
tied to a specific connection:

1. Cold-start deafness: concurrent subscribes (two channels at launch, or
   a subscribe retry racing connect) make ConnectionManager's .connecting
   wait path return the same connection to multiple connect() callers, and
   each used to run handleConnected → conn.events. Reproduced
   deterministically with an asy... (continued)

Coverage Stats

76 of 83 new or added lines in 5 files covered. (91.57%)

8 existing lines in 1 file now uncovered.

7263 of 8890 relevant lines covered (81.7%)

36.31 hits per line