krakjoe / parallel / 27606194673

95%

Build Type

push

github

Committed by web-flow

Commit Message

Narrow crash handler to undefined-function calls only (#378)

The SIGSEGV/VEH handler added in #355 caught *every* fault on a parallel
worker thread and converted it into a catchable IllegalInstruction error
via zend_bailout(). This masked genuine bugs (no backtrace, no core dump)
and longjmp-ing out of a signal handler is not async-signal-safe.

Restrict the conversion to the single case it was built for: a worker
faulting on a ZEND_INIT_FCALL to a function that is not in the worker's
function table (i.e. not provided via a bootstrap file). Any other fault
now falls through to the previous handler so it crashes properly with a
backtrace / core dump.

Coverage Stats

0 of 15 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

2906 of 3055 relevant lines covered (95.12%)

5681.07 hits per line