nephila / giturlparse / 27601073548

96%

push

github

Fix path/branch extraction stripping every marker occurrence (#152)

GitHubPlatform and GitLabPlatform built `path`/`branch` with
str.replace(marker, ""), which removes *every* occurrence of the
marker rather than only the leading one. A URL whose file path or
branch name contained the same segment again was silently corrupted:

    parse('.../blob/main/src/blob/utils.py').path  -> 'main/srcutils.py'
    parse('.../tree/feature/tree/x').branch        -> 'featurex'

The leading marker is already guaranteed by the preceding startswith
check, so slice it off instead. Slicing (rather than str.removeprefix)
keeps the declared Python 3.8 compatibility. Adds regression tests for
nested /blob/ paths and /tree/ branch names on both GitHub and GitLab.

Co-authored-by: patchwright <292882882+patchwright@users.noreply.github.com>

41 of 42 branches covered (97.62%)

Branch coverage included in aggregate %.

241 of 251 relevant lines covered (96.02%)

3.84 hits per line