dangernoodle-io / breadboard / 27591008068

100%

push

github

fix(bb_tls_creds): heap-allocate the 4KB NVS read buffer — main-task stack overflow on TLS+http-sink boot (hardware-validation crash, F9) (#450)

- the 3584-byte main-task stack (CONFIG_ESP_MAIN_TASK_STACK_SIZE=3584) is smaller than the 4096-byte NVS read buffer that resolve_one() declared on the stack; a single call to bb_tls_creds_resolve from the PRE_HTTP tier (bb_sink_http session_ensure, gated #if BB_HTTP_TLS_ENABLE) overflows the entire main-task stack and triggers vApplicationStackOverflowHook → crash-loop at boot
- crash-loop confirmed on hardware: TLS-enabled build with http telemetry sink, decoded backtrace vApplicationStackOverflowHook → esp_system_abort → panic_abort at PRE_HTTP init
- fix: heap-allocate the NVS read buffer (malloc/free per resolve_one call) matching the existing dup_pem heap pattern; peak heap is one 4 KB buffer at a time, not on the stack; the fix is active for all three resolve_one call sites (CA/cert/key) sequentially so peak is 4 KB
- plaintext builds unaffected (NVS path still skipped when override_pem is set; ns=NULL skips the block entirely)
- add BB_TLS_CREDS_TESTING allocator injection hook (bb_tls_creds_set_malloc / bb_tls_creds_reset_malloc) and a new host test covering the malloc-failure path returning BB_ERR_NO_SPACE

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

1615 of 1615 branches covered (100.0%)

Branch coverage included in aggregate %.

2702 of 2702 relevant lines covered (100.0%)

1201.71 hits per line