medplum / medplum / 27569302481

92%

push

github

Transaction scoped repos (#9285)

* Repository locked during transaction processing

Prevents unexpected transaction interleaving. Consider

repo.withTransaction(() => { ... });
repo.withTransaction(() => { ... });

Note the lack of awaits.

Previously, this resulted in
BEGIN
SAVEPOINT sp2
RELEASE SAVEPOINT sp2
COMMIT

Instead of the expected
BEGIN
COMMIT
BEGIN
COMMIT

Signed-off-by: Matt Long <ml@medplum.com>

* Do not provide client in withTransaction callback

It is no longer the right level of abstraction now that
a Repository is provided as a callback parameter.

Signed-off-by: Matt Long <ml@medplum.com>

* Use transaction repo correctly

Signed-off-by: Matt Long <ml@medplum.com>

* Add eslint rule for repo transactions

Signed-off-by: Matt Long <ml@medplum.com>

* [autofix.ci] apply automated fixes

* Avoid runtime guarding

Signed-off-by: Matt Long <ml@medplum.com>

* Sonar feedback

Signed-off-by: Matt Long <ml@medplum.com>

* More test coverage

Signed-off-by: Matt Long <ml@medplum.com>

* Add more spelling words

Signed-off-by: Matt Long <ml@medplum.com>

* Generic Repository is back

Signed-off-by: Matt Long <ml@medplum.com>

* Tighter transaction-scoped repo lifecycel checks

Signed-off-by: Matt Long <ml@medplum.com>

* Fix gap when preventing competing .withTransction

Signed-off-by: Matt Long <ml@medplum.com>

* Remove unneeded transaction wrappers

Signed-off-by: Matt Long <ml@medplum.com>

* Consolidate transactin-related tests

Signed-off-by: Matt Long <ml@medplum.com>

* Rework some transaction-related tests

Signed-off-by: Matt Long <ml@medplum.com>

* Chained pre-commits, explicitly disallow chained post-commits

Before, pre-commits that queue pre-commits would be silently
ignored.

Signed-off-by: Matt Long <ml@medplum.com>

* Use state lock in withStatementTimeout

Signed-off-by: Matt Long <ml@medplum.com>

* Increment pinDepth after successful query

Signed-off-by: Matt Long <ml@medplum.com>

* Scope-based repo connection

Signed... (continued)

24685 of 27490 branches covered (89.8%)

Branch coverage included in aggregate %.

285 of 298 new or added lines in 25 files covered. (95.64%)

37054 of 39264 relevant lines covered (94.37%)

23257.56 hits per line