kiva / ui / 27566314849

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix: convert /lend/:category guard to redirect (#6987)

* fix: [MP-2906] convert /lend/:category guard to redirect for SSR 301

The previous `beforeEnter` guard on `/lend/:category` set
`window.location.href` on the client and threw `{ url, code: 301 }` on SSR
to hand off to `/lend-by-category/:category` (which is served externally).
On SSR this was broken: Vue Router invokes `beforeEnter` during
`router.push(url)`, and the rejection was swallowed by the
`.catch(() => {})` in `src/router/index.js`. The route then resolved with
no component, producing a 404 instead of the intended 301.

Switching to a `redirect` function moves the hook into the matcher path
(`handleRedirectRecord`), which is called synchronously inside
`pushWithRedirect`. The SSR throw now propagates out of `router.push()`
before any `.then/.catch` and surfaces in `server/vue-middleware.js`'s
`handleError`, which issues the 301.

On the client the function returns `url` so Vue Router has a valid
redirect target. Without a return value, `handleRedirectRecord` would
read `.path` on `undefined` and throw "Invalid redirect" (dev) or a
TypeError (prod) right after `window.location.href` is set — a spurious
error captured by Sentry even though the browser navigation succeeds.

Also removed the unreachable `: '/lend-by-category'` fallback (the
`:category` param is required for the route to match) and added a
comment explaining why this entry uses a side-effect handoff instead of
the declarative string redirect used elsewhere in the file.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix: not used route removed

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

5257 of 5781 branches covered (90.94%)

Branch coverage included in aggregate %.

4 of 8 new or added lines in 1 file covered. (50.0%)

47 existing lines in 3 files now uncovered.

41326 of 49256 relevant lines covered (83.9%)

35.87 hits per line