medplum / medplum / 27561095645

92%

Build Type

push

github

Committed by web-flow

Commit Message

Server: Scheduling Parameters can be inherited from HealthcareService (#9453)

* Schedule can inherit SchedulingParameters from HealthcareService

When a Practitioner defines their availability, they may not intend to
deviate from other practitioner's scheduling setup, particularly with
respect to fields like `duration` and `alignmentInterval` (as these must
match across Schedule resources to be jointly used in $find/$book).

In this commit our goal is to prefer values set within an individual
schedule, but fall back to values set on the HealthcareService when the
value in the schedule is not set.

To that end, I'm splitting up the original parsing logic into two
functions, one that only handles `HealthcareService` input, and one that
only handles `Schedule` input.

While these two methods have a lot of similarity, they are continuing to
diverge. We may want to re-unify later when we understand more, but for
now having them separate improves the readability of each layer.

- Follow up needed: How can we retain useful error messages in this more
  complex structure?

https://github.com/medplum/medplum/issues/8383

Signed-off-by: Noah Silas <noah@medplum.com>

* Add LayeredDict to track complex scheduling parameter provenance

In this commit we add a data structure that lets us track the provenance
of configuration "layers".

Example: Trying to find availability for a given Schedule might involve:
- A static defaults object
- values coming a HealthcareService SchedulingParameters extension
- values coming from a Schedule SchedulingParameters extension
- a timezone coming from an extension on the schedule's Actor

Let's try to express this in a way that lets us access individual
configuration quickly in the common case, and still find the source of
each setting in an error scenario.

Signed-off-by: Noah Silas <noah@medplum.com>

* Update `defining-availablity` docs for inherited parameters

When folks are defining per-schedule fields (most commonly,
`ava... (continued)

Coverage Stats

24644 of 27445 branches covered (89.79%)

Branch coverage included in aggregate %.

86 of 90 new or added lines in 5 files covered. (95.56%)

4 existing lines in 1 file now uncovered.

36967 of 39176 relevant lines covered (94.36%)

23183.11 hits per line