safe-global / safe-client-gateway / 27557496345

90%

Build Type

push

github

Committed by web-flow

Commit Message

fix(hooks): invalidate nested Safe tx cache on parent approveHash execution (#3114)

* fix(hooks): invalidate nested Safe tx cache on parent approveHash execution

In nested-Safe setups a child transaction is confirmed/executed when a parent
Safe executes approveHash(childSafeTxHash) on the child Safe. The tx-service
emits EXECUTED_MULTISIG_TRANSACTION for the parent's approveHash tx, but the
handler only invalidated the parent caches, leaving the child tx and the child
Safe's queue stale until TTL.

Decode the executed tx's calldata with SafeDecoder and, when it is an
approveHash (directly or wrapped in a multiSend), also clear the referenced
child transaction and its Safe's transaction list. The child Safe address is
the approveHash call's `to`.

Resolves WA-2032.

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(hooks): recurse nested multiSends; cover undefined/mixed/recursive cases

Address review feedback on the nested-Safe approveHash invalidation:

- Make approveHash detection recursive over multiSend, via a new private
  collectApprovedHashes(data, callee) walker. This handles arbitrary-depth
  multiSend nesting (e.g. multiSend([multiSend([approveHash(...)])])), which
  rare relayer wrappers can produce.
- Add tests for:
  - executed events with no `data` (early-return path),
  - multiSend that mixes approveHash with other calls — asserts only the
    approveHash child is cleared and an unrelated Safe queue is untouched,
  - nested multiSend batches.
- Document that we invalidate regardless of `event.failed` (intentional:
  cheap and always-correct).
- Document the selector-only `isApproveHash` trust boundary: the
  decodeFunctionData try/catch is what makes malformed/colliding input safe.
- Slim the inline comment block to one line; the JSDoc on the helper carries
  the long-form rationale.

Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude... (continued)

Coverage Stats

4621 of 5493 branches covered (84.13%)

Branch coverage included in aggregate %.

25 of 26 new or added lines in 2 files covered. (96.15%)

2 existing lines in 2 files now uncovered.

17103 of 18563 relevant lines covered (92.13%)

611.54 hits per line