27555294424
63%

Ran 15 Jun 2026 03:02PM UTC

Jobs 1

Files 40

Run time 1min

Badge

Embed ▾

Committed 15 Jun 2026 02:58PM UTC coverage: 62.504%. Remained the same

Build # 27555294424

Build Type

push

github

Committed by

web-flow

Commit Message

fix(cache): use status code (not identity) to detect Service AlreadyExists (#3507)

The `cache` dataset initializer compared the exception instance to the
`ConflictError` class using `is`, which is always False:

    except ApiException as e:
        if e is ConflictError:  # always False

`core_v1.create_namespaced_service()` raises a plain `ApiException` with
`status=409`, not a `ConflictError`, so this branch was unreachable. When
the Service already existed (e.g., re-reconcile after a crash between
Service creation and LWS readiness), the code re-raised, fell into the
outer cleanup, and deleted the ServiceAccount — leaving the cache
cluster in a broken state.

Match the pattern used a few lines above for the ServiceAccount and
check `e.status == 409` instead.

Add a unit test that mocks `create_namespaced_service` to raise 409 and
asserts `download_dataset` completes without calling
`delete_namespaced_service_account`.

Signed-off-by: 1fanwang <1fannnw@gmail.com>

Coverage Stats

2212 of 3539 relevant lines covered (62.5%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	27555294424.1	15 Jun 2026 03:02PM UTC	40	62.5	GitHub Action Run

kubeflow / trainer / 27555294424
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 27555294424

kubeflow / trainer / 27555294424 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 27555294424

kubeflow / trainer / 27555294424
63%

README BADGES
x