dangernoodle-io / breadboard / 27549170159

100%

push

github

fix(bb_health): health.ok uses the same ota_validated source as /api/info (hardware-validation regression) (#448)

- bb_health_compute_ok() was calling bb_ota_is_validated() which uses strict semantics
  (== ESP_OTA_IMG_VALID), while /api/info's ota_validated uses lenient semantics
  (!= ESP_OTA_IMG_PENDING_VERIFY via bb_board_get_info()). on non-rollback /
  direct-flash / UNDEFINED-partition builds these disagree: /api/info shows
  ota_validated:true but health.ok returns false. confirmed on wroom32 hardware.
- fix: change bb_health_compute_ok() to use bb_board_get_info().ota_validated so
  health.ok always agrees with the displayed validated state. bb_ota_is_validated()
  is left unchanged — its strict semantics are required by the OTA rollback/retry
  logic in bb_wifi.c.
- bb_pub_health benefits automatically via the SSOT change (HPR-2): the telemetry
  ok field now also uses the lenient source.
- add BB_WIFI_TESTING and BB_BOARD_TESTING test injection hooks so host tests can
  assert ok=true when both conditions are satisfied; four new compute_ok test cases.
- coverage: 100% lines/functions/branches.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>

1615 of 1615 branches covered (100.0%)

Branch coverage included in aggregate %.

2702 of 2702 relevant lines covered (100.0%)

1181.38 hits per line