KarpelesLab / libwallet / 27535646822

24%

Build Type

push

github

Committed by MagicalTux

Commit Message

wltwallet: fix dkls23 RemoteKey wrapper mismatch + activate real-infra tests + bump 0.4.61

Two findings surfaced when we wired the test ClientID
(com.ellipx.walletapp) via TestMain and removed the hard t.Skip
on TestRemoteWallet / TestEdDSALocalToRemoteReshare:

1. dkls23 RemoteKey shares were uploaded in the wrong wire shape.
   libwallet wraps the dklstss.Save() bytes in dklsKeyWrapper{Data:
   bytes} so they round-trip through the local JSON encrypt path
   (the wrapper exists because dklstss.Save() is binary and doesn't
   marshal as JSON on its own). But the SAME wrapper is what gets
   uploaded to Crypto/WalletSign:setGeneratedKey, and wdrone's
   loadShare unmarshals the decrypted bottle into a `[]byte` target:

       case "dkls23":
           var raw []byte
           if _, err = op.UnmarshalCbor(dat, &raw); err != nil { ... }

   The cryptutil opener reads the bottle's `ct` header ("json"
   because libwallet uses MarshalJson) and runs json.Unmarshal(buf,
   *[]byte). A bare []byte JSON-marshals to a base64 string and
   round-trips straight back into []byte; the wrapper object
   ({"data":"..."}) fails with `cannot unmarshal object into Go
   value of type []uint8` — which is exactly the wdrone error
   TestRemoteWallet caught against the live fleet.

   RemoteKey shares are never decrypted client-side (they live on
   wdrone), so the wrapper is purely local-convenience for that
   type. encrypt() now keeps the wrapper for StoreKey / Password
   (decryptDkls23 still expects it) and ships raw Save() bytes for
   RemoteKey. Verified by running TestRemoteWallet 3× against the
   live backend: 2/3 PASS (15s and 108s), 1/3 SKIP on peer-ping
   flake — full create → upload → reshare → re-upload succeeds.

2. TestRemoteWallet was passing all 3 wallet keys as the reshare
   old committee. ReshareDkls's guard `requires exactly T+1=2 old
   signers in the active subset, got 3` rejected this. Now picks
   one Plain + the RemoteKey, the same shape an ... (continued)

Coverage Stats

19 of 19 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

4427 of 18744 relevant lines covered (23.62%)

100.55 hits per line