kubeflow / trainer / 27533231742

63%

master: 63%

Build Type

Pull #3602

github

Committed by Sridhar1030

Commit Message

fix(controller): merge resourcesPerNode with Runtime container resources

When a TrainJob sets resourcesPerNode, merge it with the referenced
Runtime's node container resources instead of replacing the entire block.
TrainJob keys override matching keys; unset keys inherit from the Runtime.

This fixes the case where specifying only GPU silently drops CPU/memory
from the Runtime and pushes pods to BestEffort QoS.

Fixes kubeflow/trainer#3551

Signed-off-by: Sridhar1030 <sridharpillai75@gmail.com>

Pull Request Pull Request #3602: fix(controller): merge resourcesPerNode with Runtime container resources

Coverage Stats

34 of 36 new or added lines in 1 file covered. (94.44%)

19 existing lines in 1 file now uncovered.

2245 of 3574 relevant lines covered (62.81%)

0.73 hits per line