codeigniter4 / CodeIgniter4 / 27526250084

88%

push

github

fix: `env()` TypeError for non-string `$_SERVER` values + `esc()` fixes (#10305)

* fix: env() TypeError for non-string $_SERVER values + esc() fixes

- env(): guard non-string values (int argc, array argv in CLI) before
  strtolower() to prevent TypeError under declare(strict_types=1)

- esc(): propagate $encoding in recursive array calls (was ignored before),
  add early return after array processing, replace single static $escaper
  with static $escapers[] cache keyed by encoding

- tests: data-provider test for env() non-string types,
  three tests for esc() foreach reference leak

* Apply suggestion from @michalsn

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* Apply suggestion from @michalsn

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* Update system/Common.php

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* style: cs-fix

* test: add tests for esc() encoding changes and update changelog

* Update tests/system/CommonFunctionsTest.php

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

* docs: move env/esc fix changelog entry to v4.7.4.rst

* docs: split Common changelog entry

---------

Co-authored-by: Michal Sniatala <michal@sniatala.pl>

9 of 9 new or added lines in 1 file covered. (100.0%)

22187 of 25129 relevant lines covered (88.29%)

211.17 hits per line