OneBusAway / watchdog / 27521066441

51%

main: 51%

Pull #112

github

fix(config): validate OBA server configs and drop invalid entries

A production service-discovery file with null feed URLs (gtfs_url,
vehicle_position_url, agency_id) unmarshalled to empty strings, producing
endless cryptic `Get "": unsupported protocol scheme ""` errors on every
fetch cycle.

- Add ValidateServer to check required fields (id, name, oba_base_url,
  oba_api_key, gtfs_url, vehicle_position_url, agency_id); trip_update_url
  and the GTFS-RT auth pair stay optional.
- filterValidServers drops invalid servers and reports each to Sentry, so
  one bad entry can't block monitoring of the whole fleet. Wired into both
  loadConfigFromFile and loadConfigFromURL (covers startup + remote refresh).
- Initialize Sentry before loading config in main.go, so startup-time
  validation/load errors are actually delivered instead of captured by an
  uninitialized hub.

42 of 53 new or added lines in 3 files covered. (79.25%)

993 of 1934 relevant lines covered (51.34%)

0.56 hits per line