umputun / ralphex / 27514928831

84%

master: 84%

Build Type

Pull #383

github

Committed by vlondon

Commit Message

fix: handle task retry/backwards moves and tasks-only completion in plan panel

addresses two pre-existing edge cases umputun raised on PR #383, fixed
in both the file-parse paths (tail.go/session_progress.go) and the
in-process path (broadcast_logger.go) so the behavior matches.

retry / backwards section numbers:
the 'task iteration N' number is NextPlanTaskPosition(), not a monotonic
counter. previously any new task_start emitted a task_end for the current
task first, so a timeout/FAILED retry (same N) flipped the task done then
back to active, and a mid-run checkbox uncheck (N goes backwards) marked
the higher task done. now task_end fires only on forward progress to a
higher-numbered task or on a transition out of the task phase.

tasks-only final task:
--tasks-only runs end on the COMPLETED signal with no following section
and no phase transition, so the final task never got a task_end (in
broadcast_logger, onPhaseChanged never fires; in the file path, there is
no next section). now a COMPLETED signal closes the active task, emitted
before the signal event so client terminal cleanup finds no active task.
only COMPLETED closes a task; FAILED leaves it for terminal cleanup.

extracted taskEndEvent/taskEndOnCompletion helpers (task_end always
tagged status.PhaseTask). tests cover retry, backwards, COMPLETED-closes,
FAILED-does-not-close, and the tasks-only loader path.

Pull Request Pull Request #383: fix: plan panel marks finished tasks done and scrolls to the active task

Coverage Stats

116 of 119 new or added lines in 4 files covered. (97.48%)

7 existing lines in 4 files now uncovered.

7758 of 9276 relevant lines covered (83.64%)

227.09 hits per line