umputun / ralphex / 27514264632

84%

master: 84%

Build Type

Pull #383

github

Committed by vlondon

Commit Message

fix: address review feedback on plan-panel task boundaries

- tag task_end with status.PhaseTask instead of the incoming section's
  phase, so a task closed by a review/codex transition still buckets
  under the task section in the main output stream (matches
  BroadcastLogger.onPhaseChanged, which tags task_end with the old task
  phase). does not affect the plan panel, which only reads task_num.
- drop the unused named returns on buildPendingSectionEvents to keep the
  signature honest (body returns the locals explicitly).
- add Session.getLastTask() to match the getLastOffset/getLastPhase
  accessor convention; tests now use it instead of reaching into the
  field under a manual RLock.
- app.js: scrollIntoView uses block:'nearest' instead of 'start' so it
  confines scrolling to the plan panel rather than nudging the whole
  page when the panel is off-screen.
- tests assert task_end carries PhaseTask while the triggering section
  carries its own phase.

Pull Request Pull Request #383: fix: plan panel marks finished tasks done and scrolls to the active task

Coverage Stats

87 of 90 new or added lines in 3 files covered. (96.67%)

2 existing lines in 2 files now uncovered.

7736 of 9251 relevant lines covered (83.62%)

226.98 hits per line