FlexMeasures / flexmeasures / 27513608133
86%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 166
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.837% (+0.1%) from 80.723%
27513608133

push

github

web-flow 
fix: allow root assets to have non-unique names (#2226)

* fix: allow root assets to have non-unique names

Signed-off-by: Nicolas Höning <nicolas@seita.nl>

* fix: define account-scoped root asset index

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* fix: migrate account-scoped root asset index

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* fix: validate root asset names by account

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* test: cover root asset model uniqueness

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* test: cover root asset API uniqueness

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* test: avoid duplicate planning root asset name

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* Update documentation/changelog.rst

Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: Mohamed Belhsan Hmida <149331360+BelhsanHmida@users.noreply.github.com>

* fix: reuse toy root assets by account

The Docker build workflow runs `flexmeasures add toy-account` first and later runs `flexmeasures add toy-account --kind process` against the same database.

After adding account-scoped uniqueness for root asset names, the second command could no longer insert another top-level `toy-building` for the same account. Look up toy assets by the same identity that the database enforces instead: root assets by account/name and child assets by parent/name.

Signed-off-by: Mohamed Belhsan Hmida <mohamedbelhsanhmida@gmail.com>

* test: cover repeated toy account setup

Cover the Docker tutorial sequence where the battery toy account is created before extending the same account with process assets.

The regression checks that the second command reuses the existing root `toy-building`, keeps one root `toy-process`, and still adds the expected process sensors.

Signed-off-by: Mohamed Belhsan H... (continued)

13309 of 16464 relevant lines covered (80.84%)

0.81 hits per line

Coverage Regressions

Lines Coverage ∆ File
85
78.84
 0.0% flexmeasures/data/models/generic_assets.py
24
70.81
 2.84% flexmeasures/cli/data_add.py
8
87.76
 0.48% flexmeasures/data/schemas/generic_assets.py
Jobs
ID Job ID Ran Files Coverage
1 27513608133.1 166
80.84
 GitHub Action Run
Source Files on build 27513608133