umputun / revdiff / 27509372817

90%

master: 90%

Pull #228

github

fix: cover herdr backend in launcher tests and add it to plan-review launcher

The launcher test (TestShellLaunchersPreserveAnnotationExitCode) did not
isolate the herdr backend. cleanOverlayEnv() left HERDR_ENV / HERDR_SOCKET_PATH
/ HERDR_PANE_ID in the env, and mergeEnv() only strips override keys, so running
the suite inside a live Herdr session inherited HERDR_ENV=1 and ran the real
herdr backend (tab create / pane run / sentinel-wait) for every backend case
checked after the herdr branch, spawning tabs and hanging. The herdr backend
was also never exercised in isolation.

- cleanOverlayEnv() scrubs the three HERDR_* vars
- launcherBackends() gets a herdr case with a fake herdr fixture (tab create ->
  JSON ids satisfying both the jq and grep parse paths; pane run -> runs the
  launch command then reports success; tab close -> noop)
- launch-plan-review.sh gains the same herdr branch (before kitty) the two
  revdiff launchers already have; the test exercises all three launchers and the
  plan-review one was missing it

24 of 25 new or added lines in 3 files covered. (96.0%)

10151 of 11274 relevant lines covered (90.04%)

3173.09 hits per line