ArduPilot / MethodicConfigurator / 27505726197

94%

push

github

feat(connection renames): support multi-digit connection numbers in _generate_connection_renames

Previously, new_connection_prefix[:-1] and new_connection_prefix[-1]
only correctly extracted the type and number for single-digit
connection prefixes (e.g. CAN2, SERIAL3).

For multi-digit prefixes like BATT12, this incorrectly split the
prefix into type=BATT1, number=2 instead of type=BATT, number=12,
causing the connection rename feature to produce wrong parameter
names.

Fixed by using a regex to split the prefix into the alphabetic type
and the full numeric suffix, regardless of digit count.

Add three regression tests covering single-digit, multi-digit,
and invalid prefixes.

1958 of 2029 branches covered (96.5%)

12462 of 13192 relevant lines covered (94.47%)

2.83 hits per line