rust-bitcoin / rust-bitcoin / 27499174829

81%

master: 83%

push

github

Merge rust-bitcoin/rust-bitcoin#6184: 0.32.x: Add `consensus_encoding` to types present in units 1.0

<a class=hub.com/rust-bitcoin/rust-bitcoin/commit/<a class="double-link" href="https://git"><a class=hub.com/rust-bitcoin/rust-bitcoin/commit/2e1f9a0ecec391e7dc9fe12905999393b84d2505">2e1f9a0ec<a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b481a4e237778b5aadc3eee0a079b7d3f8543a9d"> Add consensus encoding fuzz target (Jamil Lambert, PhD)
<a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/50ec967029d521763f060bbfc9b8177564141137">50ec96702</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b481a4e237778b5aadc3eee0a079b7d3f8543a9d"> Add consensus_encoding support to LockTime (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/913884f92d23070eb153d8f9a2007970fc827d10">913884f92</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b481a4e237778b5aadc3eee0a079b7d3f8543a9d"> Add consensus_encoding support to CompactTarget (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/f8846e9150125cc50ef0fc0143e36386a687cf4c">f8846e915</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b481a4e237778b5aadc3eee0a079b7d3f8543a9d"> Add consensus_encoding support to Sequence (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/88f2c697780f2afa14367afb2019405ea4f09b65">88f2c6977</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b481a4e237778b5aadc3eee0a079b7d3f8543a9d"> Add consensus_encoding support to Amount (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/d17cd34f68323eadb3ebf3dd1267101be3fd482b">d17cd34f6</a><a href="https://github.com/rust-bitcoin/rust-bitcoin/commit/b481a4e237778b5aadc3eee0a079b7d3f8543a9d"> Add dependency on consensus_encoding (Jamil Lambert, PhD)
</a><a class="double-link" href="https://github.com/rust-bitcoin/rust-bitcoin/commit/7b9851dfd74e04c22ed831ff188d5b22d8eaae94">7b9851dfd Bump dependencies to .100 (Jamil Lambert, PhD)

Pull request description:

  As a first step in implementing `consensus_encoding` in `0.32.x` add impl for types that are in `units` `1.0` and in `0.32.x`.
  
  - Add `consensus_encoding` dependency to `units` and `bitcoin` (some units 1.0 types are still in bitcoin in v0.32).
  - Add `consensus_encoding` to `Amount`, `Sequence`, `CompactTarget` and `absolute::LockTime`.
    - These are a copy and paste from master with minimal changes required, described in the commit logs.
  - Bump the `base58ck` dependence in `bitcoin` to `0.1.100`. Required to remove the dependence of `0.1.0` on `internals`.
  - Add fuzzing of the new vs old impl. The slices are trimmed to the length required by the decoder since the new encoding logic reads what it needs and ignores the rest, but the legacy fails if there are trailing bytes.


ACKs for top commit:
  apoelstra:
    ACK 2e1f9a0ecec391e7dc9fe12905999393b84d2505; successfully ran local tests
  tcharding:
    ACK 2e1f9a0ecec391e7dc9fe12905999393b84d2505


Tree-SHA512: 8a62cf0583809e0cb5144ed1ba7f159438a

0 of 36 new or added lines in 4 files covered. (0.0%)

16485 of 20389 relevant lines covered (80.85%)

3500.34 hits per line