AAEmu / AAEmu / 27492224764

5%

Build Type

push

github

Committed by web-flow

Commit Message

feat(game): Party/Raid remote-member sync + ObjId refresh + optional Tag Share toggle (#1437)

* Fix TeamMember.WritePerson: include ZoneId/InstanceId/ObjId so remote members render correctly

Vanilla's WritePerson laid out 8 bytes of zero for "zi", an 8-byte angZ
double, and a single !IsOnline byte. That is not the layout the 1.2 client
expects for SCTeamRemoteMembersExPacket / SCJoinedTeamPacket: it wants the
member's current ZoneId + InstanceId, its ObjId (or 0 when offline), the
three ability slots and several padding bytes — 50 bytes total.

Without the ObjId in this snapshot, the client cannot correlate the member
back to any unit it has streamed in, so a raid-mate that's outside the
recipient's render distance shows up as "offline" with a blank HP bar.
After this patch the client knows the member's ObjId, can apply HP/MP/
position updates from the existing broadcast pipeline, and the raid UI
behaves the same whether or not the mate is currently in render.

Co-Authored-By: Evenstone <evenstone@noreply.users.github.com>

* Add periodic remote-member sync + ObjId refresh for out-of-range team-mates

ArcheAge clients track other characters by ObjId. Once a team-mate leaves
the recipient's render distance, the client forgets that mate's ObjId and
treats subsequent HP/MP/position broadcasts (which all use the ObjId as
key) as no-ops — the raid UI silently freezes for that member.

This commit adds three coordinated mechanisms inside TeamManager:

1) AreInRenderDistance(a, b)
   Region-based check: same Region or any of the 8 neighbours. Used as the
   skip-condition so we never duplicate the work the normal broadcast
   pipeline is already doing.

2) RefreshTeamMemberObjIds(team, newMember)
   Sends SCRefreshTeamMemberPacket in both directions for every existing
   team-mate that is NOT in render distance of newMember. Hooked into:
     • CreateNewTeam (target & owner can spawn far apart)
     • ReplyToJoinTeam (joining player is anywhere on the map)... (continued)

Coverage Stats

4 of 210 new or added lines in 7 files covered. (1.9%)

7 existing lines in 4 files now uncovered.

3288 of 67805 relevant lines covered (4.85%)

0.05 hits per line