tomerfiliba / plumbum / 27456614171

88%

push

github

fix(colorlib): correctness fixes (stdout guard, Color(0), from_ansi, bold-off) (#823)

* fix(colorlib): fix five correctness bugs in colorlib (issue #820)

- Guard get_color_repr() against sys.stdout being None or lacking isatty
  (pythonw / GUI embedding no longer raises AttributeError on import)
- Fix Color(0) returning reset instead of black by replacing falsy `not
  r_or_color` guard with explicit `is None or == ""` check
- Raise ColorNotFound instead of AssertionError for out-of-range int colors
  in Color.__init__ and ColorFactory.__getitem__
- Require both-or-neither of g/b positional args to Color(); raise
  ColorNotFound when exactly one is given
- Fix Style.from_ansi() to iterate all ANSI escape sequences via finditer
  (previously only the first sequence was parsed)
- Fix bold-off round-trip: parse ANSI code 22 as both bold=False and
  dim=False ("normal intensity") so str(ANSIStyle(attributes={'bold':
  False})) re-parses correctly
- (optional) Avoid side-effecting self.bg.fg in Style.ansi_codes by
  operating on a copy

Assisted-by: ClaudeCode:claude-sonnet-4.6

* test: clear FORCE_COLOR/NO_COLOR in get_color_repr stdout tests

CI sets FORCE_COLOR=3, which get_color_repr() honors before the stdout
check, so the stdout-guard regression tests must clear the color env vars
to exercise the isatty path. Fixes the #823 CI failures.

Assisted-by: ClaudeCode:claude-sonnet-4.6

1323 of 1778 branches covered (74.41%)

19 of 19 new or added lines in 2 files covered. (100.0%)

5496 of 6282 relevant lines covered (87.49%)

12.38 hits per line