mpyw / laravel-database-advisory-lock / 27455792490

100%

push

github

[Claude] Support the dedicated `mariadb` driver (closes #15) (#16)

* Support the dedicated `mariadb` driver (closes #15)

Laravel 11 introduced a dedicated `Illuminate\Database\MariaDbConnection`
(extending `MySqlConnection`) used whenever the connection driver is
`mariadb`. Because this package only registered resolvers for `mysql`
and `pgsql`, a connection configured with `'driver' => 'mariadb'` was
resolved to Laravel's own `MariaDbConnection` *without* the
`AdvisoryLocks` trait, so `advisoryLocker()` was unavailable there.

- Add `Connections\MariaDbConnection` (extends the base + uses the trait)
- Register a `mariadb` resolver in `ConnectionServiceProvider`
  - `LockerFactory` already routes it correctly via
    `instanceof MySqlConnection` (the base MariaDbConnection extends it)
- Tests: make the `mariadb` connection actually use `'driver' => 'mariadb'`
  (it previously inherited the `mysql` driver), so the whole mariadb test
  matrix now exercises the new class end-to-end

Also, while here:
- Fix a real null-safety issue flagged by PHPStan in PostgresSessionLock:
  `Connection::getEventDispatcher()` returns `Dispatcher|null`, but
  `TransactionEventHub::initializeWithDispatcher()` requires a non-null
  `Dispatcher`. Guard against a missing dispatcher.
- README: document that a transaction-level advisory lock is bound to the
  top-level transaction. With Laravel's savepoint-based nested
  transactions, committing a nested transaction does NOT release a lock
  acquired inside it (it is promoted to the enclosing transaction and held
  until the outermost one ends); only a rollback to the savepoint releases
  it early. Reliable, but it may be held longer than intended — a tradeoff
  vs session-level locks. Verified against Postgres and cited to the docs.
- Widen the supported Laravel range to `^13.0` (already in composer.json,
  was missing from the README) and proactively allow `^14.0`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthr... (continued)

3 of 3 new or added lines in 2 files covered. (100.0%)

167 of 167 relevant lines covered (100.0%)

133.32 hits per line