medplum / medplum / 27444664268

92%

main: 92%

push

github

fix(ws): tear down WebSocket subscription Redis listener on shutdown (#9494)

* fix(ws): tear down WebSocket subscription Redis listener on shutdown

The module-level pub/sub subscriber for WebSocket subscription fan-out was
never cleared when closeWebSockets ran, leaving a disconnected client in
module state after shutdown. Disconnect and reset it during WebSocket shutdown,
and register an ioredis end listener so the module reference is dropped when
the connection closes, allowing setupSubscriptionHandler to run again on bind.

Signed-off-by: Karl Pietrzak <karl@medplum.com>

* test(ws): verify subscription Redis subscriber is recreated after end

Assert that disconnecting the pub/sub subscriber clears module state via
the end listener and that binding a new WebSocket subscription socket calls
getPubSubRedisSubscriber again.

Signed-off-by: Karl Pietrzak <karl@medplum.com>

* fixed test

Signed-off-by: Karl Pietrzak <karl@medplum.com>

* [autofix.ci] apply automated fixes

* test fixes

Signed-off-by: Karl Pietrzak <karl@medplum.com>

* refactored a bit to simplify code complexity (SonarQube)

Signed-off-by: Karl Pietrzak <karl@medplum.com>

---------

Signed-off-by: Karl Pietrzak <karl@medplum.com>
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>

24572 of 27364 branches covered (89.8%)

Branch coverage included in aggregate %.

60 of 66 new or added lines in 2 files covered. (90.91%)

36847 of 39043 relevant lines covered (94.38%)

23227.98 hits per line