vocdoni / saas-backend / 27433838527

60%

main: 60%

Build Type

Pull #520

github

Committed by altergui

Commit Message

refactor(notifications): unify queue infrastructure and OTP lifecycle constants

Move the circuit-breaker and queue mechanics out of csp/notifications/ into the
top-level notifications/ package as generic, reusable types (Breaker, Queue,
QueueItem). The CSP queue becomes a thin wrapper that maps NotificationChallenge
↔ QueueItem via a Meta field and feeds NotificationsSent from the inner Done
channel — external interface unchanged.

Wire a notifications.Queue into api.API (created in New, started in Start).
Rewrite sendMail to enqueue asynchronously instead of blocking the request
goroutine on SendNotification. Add a queueNotification helper for pre-built
notifications and use it in organizationCreateTicket, which was previously
calling a.mail.SendNotification directly (no retry, no circuit-breaker).

Add CreatedAt to db.UserVerification (set in SetVerificationCode) and use it in
recoverUserPasswordHandler to enforce a per-account OTP cooldown, matching the
rate-limiting intent of the CSP OTP system.

Unify OTP lifecycle constants into notifications/:
- DefaultOTPExpiry (15 min): shared validity window for all one-time codes
  (account verification, password reset, CSP OTP challenges). Replaces the
  accidental split between apicommon.VerificationCodeExpiration (10 min) and
  csp.DefaultNotificationTTL (5 min).
- DefaultOTPCooldown (60 s): shared anti-spam rate limit between notification
  requests, used by both API password recovery and CSP token generation.
- DefaultQueueTTL bumped to 20 min (must exceed DefaultOTPExpiry).

Drop apicommon.VerificationCodeExpiration and PasswordRecoveryCooldown as
mutable package-level vars. Move the values to api.API struct fields
(otpExpiry, otpCooldown), initialized from api.Config in New() with fallback
to the notifications defaults. Tests override via testAPI directly (same-package
access). Expose both as runtime-configurable flags --otpExpiry / --otpCooldown
(VOCDONI_OTPEXPIRY / VOCDONI_OTPCOOLDOWN), wired into... (continued)

Pull Request Pull Request #520: refactor(notifications): unify API email sends with CSP queue infrastructure

Coverage Stats

278 of 349 new or added lines in 14 files covered. (79.66%)

4 existing lines in 2 files now uncovered.

8064 of 13382 relevant lines covered (60.26%)

43.14 hits per line