Logflare / logflare / f5ce4a613fe1620f4c0b08281564dadd13288cd1

81%

Build Type

push

github

Committed by web-flow

Commit Message

perf: clickhouse read connection pool overhaul (#3591)

* overhaul of clickhouse read pools

* refactor: rename backend lifecycle callbacks with on_ prefix

Rename `backend_config_changed`/`backend_deleted` to
`on_backend_config_changed`/`on_backend_deleted` for clarity, making it
self-documenting that these are invoked in reaction to a lifecycle event.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat: log caught exit when terminating read connection manager

The terminate_manager catch clause previously swallowed exits silently.
Log a warning so an unexpected exit during teardown is observable.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test: introspect read pool via public API instead of internal state

Add `ConnectionManager.get_pool_pid/1` and `get_next_recycle_at/1` so the
recycling tests can assert on observable pool state through a public API
rather than reaching into the GenServer struct with `:sys.get_state`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test: drop redundant no-pool refresh_pool assertion

The "stops the pool so the next query restarts it" test already covers
`refresh_pool/1` returning `:ok`, so the standalone no-pool case is redundant.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test: drop redundant single-manager list test

The "lists managers for multiple backends" test already asserts a started
manager appears in `list_query_connection_managers/0`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test: combine recycle_backend_local no-pool and active-pool cases

Both cases share a started ConnectionManager, so exercise the no-pool error
and the successful recycle within a single test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test: combine refresh_backend_local no-manager and active-pool cases

Exercise the no-manager `:ok` path and the active-pool stop w... (continued)

Coverage Stats

72 of 82 new or added lines in 6 files covered. (87.8%)

2 existing lines in 1 file now uncovered.

13069 of 16126 relevant lines covered (81.04%)

3796.35 hits per line