stacklok / toolhive / 27424866932

67%

Build Type

push

github

Committed by web-flow

Commit Message

Replace discovery-into-context with direct VMCP calls (#5491)

* Route Serve path through core, guard discovery

On the Serve path the core VMCP is the single authoritative, admission-
filtered source of truth, so capability aggregation must no longer flow
through the discovery-into-context middleware (which applies no admission
and would bypass authz now that it lives in the core seam).

- Store the injected core on *Server and guard the discovery middleware
  to the legacy path (s.core == nil); it is left intact, not deleted.
- Source session capabilities from core.ListTools/ListResources once at
  OnRegisterSession and route tool/resource handlers through
  core.CallTool/ReadResource with explicit identity (serve_handlers.go).
- Enforce identity binding on the core call path via a new session-layer
  ValidateCaller seam (the audited check lives in internal/security).
- Resolve audit backend enrichment from Tool.BackendID via core.LookupTool
  on the Serve path; the legacy context-based path is unchanged.

The literal "feed ListTools into ProcessPreQueriedCapabilities" wiring is
infeasible (type mismatch; the flat tool list drops the routing table's
OriginalCapabilityName), so the core's output is used directly as the
session's fixed-at-initialize set and the factory does not re-aggregate.

Implements #5442

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* Address review: audit parity, binding comment

- Resolve the Serve path's audit BackendName from the backend registry
  (BackendID -> backend.Name) so it matches the legacy path's WorkloadName
  instead of recording the raw backend ID; fall back to the ID when the
  backend is absent from the registry.
- Reword enforceSessionBinding to accurately state that the SDK Validate
  only gates existence/termination and this is the sole binding-enforcement
  point on the Serve call path.
- Read the identity binding via GetMetadataValue to avoid copying the whole
  metadata map on ev... (continued)

Coverage Stats

188 of 233 new or added lines in 6 files covered. (80.69%)

11 existing lines in 3 files now uncovered.

68251 of 102450 relevant lines covered (66.62%)

62.12 hits per line