safe-global / safe-client-gateway / 27422585176

90%

Build Type

push

github

Committed by web-flow

Commit Message

Feat/space audit log (#3163)

* feat: add space audit log foundation (flag, migration, entity, taxonomy, repository)

* feat: record audit events across all space mutations and add read API

- 16 instrumented call sites: space create/update/delete, 8 member
  actions, safes add/remove, address book upsert/delete, and the
  user-account-deletion cascade (MEMBER_LEFT accountDeleted)
- audit insert joins the business mutation's transaction; audit failure
  rolls the mutation back
- AB request approval now shares one transaction with the upsert,
  replacing the manual revert-to-pending compensation
- read API: GET /v1/spaces/:spaceId/audit-log (+/actors), ACTIVE-member
  gated, server-side email masking, payload allowlist,
  (created_at, id) ordering with clamped pagination

* tests: cover the space audit log

- space-audit.service.spec: ACTIVE-only gate, identity resolution,
  email masking, payload allowlist, pagination clamping, actors endpoint
- space-audit.repository.integration.spec: events driven through real
  instrumented mutations, rollback atomicity, append-only triggers,
  ordering/tie-break pagination, filters, distinct actors, user-deletion
  cascade
- existing specs adapted to the audit-instrumented repositories

* chore: add FF_SPACE_AUDIT_LOG to .env.sample.json

* fix: derive audit log page links from the clamped pagination values

* fix: address audit log review feedback

- record MEMBER_LEFT only for ACTIVE memberships on account deletion
- treat an empty event_type query param like an omitted one
- select only user ids when collecting active members for masking

* fix: store checksummed addresses in audit payloads + review nits

- Drop the lowercase transform; AddressSchema already yields the
  canonical EIP-55 form (review feedback)
- Narrow SpacesRepository.update/diffSpaceUpdate to the interface type
  and derive SpaceUpdatedPayload from the event schema
- Build the audit where-clause declaratively with And() bounds
- Mark targetUs... (continued)

Coverage Stats

4587 of 5469 branches covered (83.87%)

Branch coverage included in aggregate %.

317 of 336 new or added lines in 22 files covered. (94.35%)

1 existing line in 1 file now uncovered.

17063 of 18576 relevant lines covered (91.86%)

618.48 hits per line