haraka / haraka-plugin-bounce / 27394942256

97%

push

github

Release v2.2.1 (#30)

- fix: results.has can't match booleans and denied non-bounces
  - change: store isa as boolean and read it directly
  - remove some not-nots so it's easier to reason about
- fix: validate_bounce passed txn (not body) to find_bounce_headers
  - hash validation was effectively broken since b61f55a, see #29
- fix: reject_all had two bare results.has(...) calls with no assert
- fix: bad_rcpt "will not check for bad recipient" was calling reject_all vs bad_rcpt
- test: fix stubs that masked dead assertions, fixes #29
  - restore skipped tests
  - drop sinon; assert real outcomes / inject seams instead
  - coverage 107 to 141 passing tests
- refactor: extract SPF logic into lib/spf.js; bounce_spf is now an orchestrator
- SPF result logic is pure and unit-tested; DNS lookup is an injectable seam
- refactor: extract verification fns into lib/validation, pure and unit-tested
- refactor: should_skip; split validate_bounce to cut complexity
- style: deleted comments that restated the code or user oriented (belong in README)
- test: refactored against test-fixtures 1.7.0 (#27 & #28)

173 of 194 branches covered (89.18%)

Branch coverage included in aggregate %.

282 of 285 new or added lines in 3 files covered. (98.95%)

616 of 621 relevant lines covered (99.19%)

28.46 hits per line