kubeovn / kube-ovn / 27390270577

27%

Build Type

push

github

Committed by web-flow

Commit Message

fix(ovs): delete the actual duplicate policy instead of the kept one in batch dedup (#6849)

When matchLogicalRouterPolicies finds multiple logical router policies
with the same priority, match, action and nexthops, it is supposed to
keep the first one and delete the rest. The duplicate branch wrongly
appended the kept policy's UUID instead of the current duplicate's,
so the survivor was queued for deletion while real duplicates leaked.

With 3+ identical rows the survivor UUID was queued twice, making
ovsdb-server reject the whole transaction with "set contains duplicate",
which turns into LogFatalAndExit in syncNodeRoutes and crashloops the
controller at startup before workers (and the self-healing single-add
path) can run.

Align the branch with AddLogicalRouterPolicy, and defensively dedup the
uuid list in BatchDeleteLogicalRouterPolicyByUUID so a duplicated uuid
can never poison the delete transaction.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

15453 of 58657 relevant lines covered (26.34%)

0.31 hits per line