microsoft / RulesEngine / 27370742919

95%

master: 97%

push

github

Fix warmup regression: avoid per-expression AppDomain assembly scan (#740)

Since 71d59dc, CustomTypeProvider.GetCustomTypes() includes
base.GetCustomTypes(), which scans every assembly in the AppDomain for
[DynamicLinqType] types. DefaultDynamicLinqCustomTypeProvider only caches
that scan per provider instance, and RuleExpressionParser.Parse built a
new ParsingConfig + CustomTypeProvider for every expression parsed, so
the scan ran for every expression in every rule (KeywordsHelper
enumerates the full type set on each ExpressionParser construction).

For workflows with thousands of rules this regressed warmup ~6.6x
versus 5.0.3 (113.8s vs 17.3s for 20,000 rules with local params and
174 loaded assemblies). The compiled-delegate cache from #727 does not
help here because each rule expression is unique.

Fix:
- Reuse one ParsingConfig/CustomTypeProvider across parses, rebuilding
  only when ReSettings.CustomTypes is swapped (AutoRegisterInputType
  replaces the array on workflow registration).
- Memoize the merged custom-type set in CustomTypeProvider; it is fixed
  after construction but was rebuilt (including the assembly scan) on
  every GetCustomTypes() call.

With this change the same 20,000-rule benchmark warms up in 16.3s,
matching 5.0.3, with identical rule results. Addresses the remaining
root cause behind #707.

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

459 of 578 branches covered (79.41%)

16 of 16 new or added lines in 2 files covered. (100.0%)

841 of 887 relevant lines covered (94.81%)

568.85 hits per line