Azure / ARO-RP / 27370015247
39%

DEFAULT BRANCH: master
Ran
Jobs 6
Files 971
Run time 2min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 38.632% (+0.006%) from 38.626%
27370015247

push

github

web-flow 
TypeSpec migration milestone 1: Generate Swagger from TypeSpec (#4791)

* Copy TypeSpec files from azure-rest-api-specs and common-types from ARO-HCP

Modelling `api` directory structure after ARO-HCP's

* Prepare container image for use in TypeSpec `make` targets

- `api/package.json` came from ARO-HCP; I removed Autorest
- Ran `npm install` on my Mac to initialize `api/package-lock.json`
- Created `Dockerfile.typespec` by copying `Dockerfile.autorest` and tweaking

Note that I considered combining the Autorest and TypeSpec stuff into a unified "api tooling" image, but I ended up in dependency hell trying to get the Autorest implementation of `make client` working and so decided to use separate images (we theoretically don't need Autorest anymore anyway)

* Add `make generate-swagger-typespec` and preserve previous `make generate-swagger` as `make generate-swagger-legacy`

We probably don't need the old one anymore, but preserving it on the off chance that we do; it doesn't hurt anything

* `make generate` and make `api` the source of truth for the current stable API, the only one we're generating from TypeSpec so far

Motivation to use `api` as the source of truth for the current API version and newer ones is that it makes it easier to commit to upstream since the directory structures match; I think this outweighs the minor confusion/inconvenience of having two sets of Swagger API specs in two different places

Other note: the new `make` target generates the examples with `oav` (referenced in ARO-HCP docs and used for their examples), and the examples seem to have changed between Autorest and `oav`; so these new examples are technically different from what's currently present in azure-rest-api-specs for this API version, but I say we don't worry about this until/unless it becomes a problem

* Update `make generate` to handle checksums for API versions in new `api` directory along with a few other tweaks...

- `hack/swagger` -> `hack/swagger-legacy`
... (continued)

29914 of 77434 relevant lines covered (38.63%)

0.44 hits per line

Coverage Regressions

Lines Coverage ∆ File
3
94.61
 0.67% pkg/frontend/admin_openshiftcluster_runjob.go
Jobs
ID Job ID Ran Files Coverage
1 pkg-util - 27370015247.1 317
20.69
 GitHub Action Run
2 pkg-api - 27370015247.2 163
65.8
 GitHub Action Run
3 cmd - 27370015247.3 13
0.0
 GitHub Action Run
4 pkg-other - 27370015247.4 298
32.64
 GitHub Action Run
5 pkg-frontend - 27370015247.5 104
74.66
 GitHub Action Run
6 pkg-operator - 27370015247.6 76
48.55
 GitHub Action Run
Source Files on build 27370015247