omry / omegaconf / 6ca9a791-7f6e-4603-925f-2f0acf45c0b3
100%
master: 100%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 20
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 100.0%. Remained the same
6ca9a791-7f6e-4603-925f-2f0acf45c0b3

push

circleci

web-flow 
Fix nested readonly structured config merges (#1318)

* Improve relative interpolation missing-key errors

Report both the original relative interpolation key and the resolved lookup path when a relative interpolation cannot be found. This makes failures such as ${..b} under a.a.a point to the original `..b` lookup and the resolved `a.b` path.

Keep resolved-key diagnostic formatting best-effort so failures while computing the display path do not mask the intended InterpolationKeyError.

Add regression coverage for single-dot and parent-relative missing interpolation diagnostics, plus the diagnostic-formatting fallback.

Closes #1126

* Fix nested readonly structured config merges

OmegaConf.merge() and OmegaConf.unsafe_merge() construct their results by mutating an internal merge target. Nested frozen structured configs can carry explicit readonly flags on destination containers, so recursive merge writes into those containers could raise ReadonlyConfigError even though public merge_with() is the operation that should reject readonly mutation.

Thread a private _allow_readonly_target flag through the merge internals so non-public merge construction can temporarily relax a destination container's local readonly flag, then restore the saved flag after the merge. Keep public merge_with() semantics unchanged.

Add regression coverage for OmegaConf.merge() and OmegaConf.unsafe_merge() with nested frozen structured configs, their input mutation contracts, and nested readonly flag restoration.

Fixes #1102

3819 of 3819 relevant lines covered (100.0%)

1.0 hits per line

Jobs
ID Job ID Ran Files Coverage
1 6ca9a791-7f6e-4603-925f-2f0acf45c0b3.1 20
100.0
 CircleCI Job
Source Files on build 6ca9a791-7f6e-4603-925f-2f0acf45c0b3