decentraland / builder-server / 27357486919

71%

push

github

fix: run migrations in ts-node transpile-only mode to prevent OOM (#806)

* fix: run migrations in ts-node transpile-only mode to prevent OOM

The migration step (`migrate:docker`) registers ts-node with the project
tsconfig, which defaults to full type-checking. Because tsconfig `include`
is `./**/*`, ts-node builds and type-checks a program spanning the entire
repo (~238 source files) just to run migrations, holding the whole
TypeScript program and checker in memory.

Under Node 18 (libuv 1.44) the heap ceiling was sized off host physical
memory, so this fit. Node 24 (#804) reads the cgroup v2 limit and
auto-sizes old-space to ~512 MB, which the type-checking working set
exceeds, crashing the migration with "Reached heap limit" / "Ineffective
mark-compacts" OOM errors. This is the same root cause as #805, but that
fix only capped the heap on the server process, not the migration.

Switch the migration ts-node to transpile-only. Migrations are already
type-checked at build time (`npm run build`) and `isolatedModules` makes
per-file transpilation safe, so runtime type-checking was pure waste.
This removes the memory hog and speeds migrations up.

Also set NODE_OPTIONS=--max-old-space-size=1536 for the migration step in
entrypoint.sh, giving migrations the same explicit, deterministic heap
ceiling as the server (they share the same 2 GB container).

* fix: scope migration NODE_OPTIONS to the migrate command

Previously NODE_OPTIONS was exported for the whole shell session, so it
also applied to the server process at the end of the script. Both used the
same value (1536) so there was no functional impact, but it was a
maintenance hazard: adjusting the server's explicit flag without noticing
the export would produce confusing behavior.

Set NODE_OPTIONS as a command prefix on the migrate invocation only so it
cannot leak to the server process below.

1375 of 2151 branches covered (63.92%)

Branch coverage included in aggregate %.

3257 of 4343 relevant lines covered (74.99%)

41.75 hits per line