mozilla-releng / balrog / #5562

90%

push

circleci

feat: capture and send metrics for all types of signing errors (#3815)

Previously we were only capturing data on errors that resulted from a request to Autograph that actually returned a response. This missed connection errors, ssl errors, etc.

This change groups two new metrics, one for errors related to the request, and one for other errors (mostly as a "make sure we don't miss any unpredictable errors handler"). The former could be broken out further into more specific requests errors, but it's difficult to imagine what that would gain us. (In the cases I can imagine, simply knowing that "yep, we didn't get a response to autograph" seems like it ought to be enough.)

2192 of 2574 branches covered (85.16%)

Branch coverage included in aggregate %.

14 of 15 new or added lines in 1 file covered. (93.33%)

5768 of 6276 relevant lines covered (91.91%)

0.92 hits per line