shader-slang / slang-rhi / 27355315222

68%

push

github

Fix #772: suppress MSVC C5285 from vendored doctest (#773)

* Fix shader-slang/slang-rhi#772: suppress MSVC C5285 on doctest in slang-rhi-tests

MSVC 14.51.x (GitHub Windows runner image v20260520.533) newly emits C5285 on
doctest's vendored std::tuple forward declaration at
external/doctest/doctest.h(539). Because slang-rhi-tests builds with /WX, the
warning is promoted to error C2220, breaking the Windows release build on both
x86_64 and aarch64. The header is unchanged third-party code -- this is
toolchain drift, not a source regression.

Suppress C5285 with /wd5285, MSVC-only and scoped PRIVATE to slang-rhi-tests
(the only target linked to doctest), so the shared warning policy and all other
targets keep the warning.

Co-authored-by: Harsh Aggarwal <haaggarwal@nvidia.com>

* Attach C5285 suppression to the doctest target instead of slang-rhi-tests

Per review on shader-slang/slang-rhi#773, move the /wd5285 MSVC-only warning
suppression from the slang-rhi-tests target onto the doctest INTERFACE library,
so the workaround travels with the header that triggers C5285 (doctest's
vendored std::tuple forward declaration). As an INTERFACE option its reach is
unchanged today -- slang-rhi-tests is doctest's only consumer -- but it attaches
the suppression to its cause and stays correct if another target links doctest.

Co-authored-by: Harsh Aggarwal <haaggarwal@nvidia.com>

---------

Co-authored-by: nv-slang-bot[bot] <274397474+nv-slang-bot[bot]@users.noreply.github.com>
Co-authored-by: Harsh Aggarwal <haaggarwal@nvidia.com>

12327 of 21092 branches covered (58.44%)

Branch coverage included in aggregate %.

36736 of 50491 relevant lines covered (72.76%)

269598.45 hits per line