opendefensecloud / solution-arsenal / 27348406272

75%

Build Type

push

github

Committed by web-flow

Commit Message

fix(controller): silently dropped cross-namespace releases in bootstrap chart (#570)

## What
Fix a bug where two same-named Releases from different namespaces
silently overwrite each other in the bootstrap chart.

## Why
`buildBootstrapInput` keyed the bootstrap `Releases` map on `ri.name` —
the bare Kubernetes Release object name. With cross-namespace
ReleaseBindings (#541) two Releases named `my-release` from different
namespaces can both survive conflict resolution and target the same
Target, colliding on the map key and dropping one deployment silently.

Fix: key on `uniqueName` instead — already guaranteed unique among
accepted releases by the resolver. Also extract the derivation rule into
a shared `effectiveUniqueName()` helper (was duplicated in both
controllers), and add a guard that returns an explicit error if
`uniqueName` is empty.

## Testing
- New `buildBootstrapInput` tests: cross-namespace collision (via full
`resolveReleaseConflicts` path) and explicit error on empty
`uniqueName`.
- `make test` / `make lint` — clean.

## Notes for reviewers
- **Upgrade path:** bootstrap map keys change from the Release object
name to `uniqueName`. Existing Targets where the two differ will have
inner FluxCD HelmReleases recreated on next bootstrap render.
- `effectiveUniqueName(rel, cv)` lives in `helpers.go`; both controllers
use it.
- Docs updated: `rendering-pipeline.md` and ADR-004 now document why
`uniqueName` is the bootstrap identity and why the object name is
unsuitable.

## Checklist
- [x] Tests added/updated
- [x] No breaking changes (or upgrade path documented above)
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Prevented release overwrites when releases share the same Kubernetes
object name across namespaces by keying bootstrap inputs by a stable
... (continued)

Coverage Stats

16 of 16 new or added lines in 3 files covered. (100.0%)

6 existing lines in 2 files now uncovered.

2638 of 3559 relevant lines covered (74.12%)

31.99 hits per line